rust-clippy
A bunch of lints to catch common mistakes and improve your Rust code. Book: https://doc.rust-lang.org/clippy/
Top Related Projects
Format Rust code
A Rust compiler front-end for IDEs
Automatically generates Rust FFI bindings to C (and some C++) libraries.
Repository for the Rust Language Server (aka RLS)
A guide to how rustc works and how to contribute to it.
Quick Overview
Rust-Clippy is a collection of lints to catch common mistakes and improve your Rust code. It's an official subproject of the Rust compiler, providing additional checks beyond what the standard Rust compiler offers. Clippy helps developers write idiomatic Rust code and catch potential bugs early in the development process.
Pros
- Extensive set of lints covering a wide range of potential issues and style improvements
- Regularly updated and maintained by the Rust community
- Integrates well with popular IDEs and build tools
- Customizable, allowing users to enable/disable specific lints
Cons
- Can sometimes produce false positives or suggest changes that may not be appropriate in all contexts
- Learning curve for understanding and configuring all available lints
- May increase compilation time, especially on larger projects
- Some lints may be overly opinionated for certain coding styles or project requirements
Code Examples
- Using Clippy in a Rust project:
#[warn(clippy::all)]
fn main() {
let x = 5;
if x == 5 {
println!("x is five");
}
}
This example demonstrates how to enable Clippy lints in a Rust file. Clippy will suggest using if x == 5
instead of if x == 5
.
- Disabling a specific lint:
#[allow(clippy::needless_return)]
fn example() -> i32 {
return 42;
}
This code shows how to disable a specific Clippy lint (in this case, needless_return
) for a particular function.
- Using Clippy with custom configurations:
# In .clippy.toml
cognitive-complexity-threshold = 30
This example demonstrates how to customize Clippy's behavior by setting a higher threshold for the cognitive complexity lint in a configuration file.
Getting Started
To use Clippy in your Rust project:
-
Install Clippy:
rustup component add clippy
-
Run Clippy on your project:
cargo clippy
-
To automatically apply Clippy suggestions:
cargo clippy --fix
For more advanced usage and configuration options, refer to the Clippy documentation.
Competitor Comparisons
Format Rust code
Pros of rustfmt
- Focuses solely on code formatting, making it simpler and more specialized
- Provides consistent and standardized code style across Rust projects
- Integrates well with various IDEs and text editors
Cons of rustfmt
- Limited to formatting; doesn't provide linting or code quality checks
- Less customizable compared to Clippy's extensive configuration options
- May not catch subtle code issues or suggest improvements
Code comparison
rustfmt example:
fn main() {
let x = 5;
println!("The value of x is: {}", x);
}
Clippy example (with a lint):
fn main() {
let mut x = 5;
x = x; // Clippy would warn about this redundant assignment
println!("The value of x is: {}", x);
}
Summary
Rustfmt and Clippy serve different purposes in the Rust ecosystem. Rustfmt is a code formatter that ensures consistent style across Rust projects, while Clippy is a linter that catches common mistakes and suggests improvements. Rustfmt is simpler and more focused, making it easier to integrate into workflows. However, it lacks the advanced code analysis capabilities of Clippy. Clippy offers more comprehensive code quality checks and customization options but may require more setup and configuration. Both tools are valuable for Rust developers, with Rustfmt ensuring consistent formatting and Clippy improving overall code quality.
A Rust compiler front-end for IDEs
Pros of rust-analyzer
- Provides a more comprehensive language server implementation for Rust
- Offers advanced IDE features like code navigation, completion, and refactoring
- Supports a wider range of editor integrations
Cons of rust-analyzer
- Larger project scope, potentially more complex to contribute to
- May have higher system resource requirements due to its comprehensive nature
Code comparison
rust-analyzer:
fn main() {
let mut x = 5;
x += 1;
println!("x = {}", x);
}
Clippy:
fn main() {
let x = 5;
let y = x + 1;
println!("y = {}", y);
}
Key differences
- rust-analyzer focuses on providing a full-featured language server for Rust, offering IDE-like capabilities across various editors
- Clippy is primarily a linter, focusing on detecting and suggesting improvements for common coding issues and style violations
- rust-analyzer aims to enhance the overall development experience, while Clippy targets code quality and adherence to best practices
- Both projects contribute significantly to the Rust ecosystem, but serve different primary purposes in the development workflow
Automatically generates Rust FFI bindings to C (and some C++) libraries.
Pros of rust-bindgen
- Automatically generates Rust FFI bindings to C and C++ libraries
- Supports complex C++ features like templates and inheritance
- Highly customizable output through command-line options and annotations
Cons of rust-bindgen
- Can produce large, complex output that may require manual refinement
- May struggle with certain C++ constructs or non-standard code
- Requires careful configuration to ensure safe and idiomatic Rust bindings
Code Comparison
rust-bindgen:
#[repr(C)]
pub struct MyStruct {
pub field1: i32,
pub field2: *mut c_char,
}
extern "C" {
pub fn my_function(arg: *mut MyStruct) -> i32;
}
rust-clippy:
fn example_function() -> i32 {
let mut x = 5;
x += 1;
x // Clippy: consider using `x.to_string()` instead
}
While rust-bindgen generates FFI bindings for interoperability with C/C++ code, rust-clippy focuses on improving Rust code quality through static analysis and linting. rust-bindgen produces Rust code that interfaces with external libraries, whereas rust-clippy analyzes existing Rust code for potential improvements and adherence to best practices.
Repository for the Rust Language Server (aka RLS)
Pros of RLS
- Provides real-time language server functionality for IDEs and editors
- Offers features like code completion, go-to-definition, and find-references
- Integrates with the Rust compiler to provide accurate and up-to-date information
Cons of RLS
- Can be slower and more resource-intensive than Clippy for large projects
- May not catch all linting issues that Clippy can identify
- Requires additional setup and configuration in some development environments
Code Comparison
RLS (example usage in VS Code settings):
{
"rust-client.channel": "stable",
"rust-client.rustupPath": "/path/to/rustup"
}
Clippy (example usage in command line):
cargo clippy -- -W clippy::all
While RLS focuses on providing IDE-like features for Rust development, Clippy is primarily a linter that helps identify potential issues and improve code quality. RLS is more suited for real-time feedback during development, whereas Clippy is often used as part of the build process or code review. Both tools complement each other in a Rust developer's toolkit, with RLS enhancing the coding experience and Clippy ensuring code quality and adherence to best practices.
A guide to how rustc works and how to contribute to it.
Pros of rustc-dev-guide
- Comprehensive documentation for Rust compiler development
- Regularly updated with detailed explanations of compiler internals
- Serves as an educational resource for understanding Rust's implementation
Cons of rustc-dev-guide
- Focuses solely on compiler development, not general Rust programming
- May be overwhelming for beginners or those not interested in compiler internals
- Less practical for day-to-day Rust development compared to Clippy
Code Comparison
rustc-dev-guide (example of compiler internals explanation):
fn type_of<T>(_: &T) -> String {
std::any::type_name::<T>().to_string()
}
Clippy (example of a lint implementation):
use rustc_lint::{LateContext, LateLintPass};
use rustc_session::{declare_lint_pass, declare_tool_lint};
declare_clippy_lint! {
pub EXAMPLE_LINT,
Warn,
"description of the lint"
}
The rustc-dev-guide provides in-depth explanations of compiler internals, while Clippy focuses on implementing lints for code analysis. rustc-dev-guide is more suitable for those interested in compiler development, whereas Clippy is practical for everyday Rust programming and code quality improvement.
Convert designs to code with AI
Introducing Visual Copilot: A new AI model to turn Figma designs to high quality code using your components.
Try Visual CopilotREADME
Clippy
A collection of lints to catch common mistakes and improve your Rust code.
There are over 700 lints included in this crate!
Lints are divided into categories, each with a default lint level.
You can choose how much Clippy is supposed to annoy help you by changing the lint level by category.
Category | Description | Default level |
---|---|---|
clippy::all | all lints that are on by default (correctness, suspicious, style, complexity, perf) | warn/deny |
clippy::correctness | code that is outright wrong or useless | deny |
clippy::suspicious | code that is most likely wrong or useless | warn |
clippy::style | code that should be written in a more idiomatic way | warn |
clippy::complexity | code that does something simple but in a complex way | warn |
clippy::perf | code that can be written to run faster | warn |
clippy::pedantic | lints which are rather strict or have occasional false positives | allow |
clippy::restriction | lints which prevent the use of language and library features1 | allow |
clippy::nursery | new lints that are still under development | allow |
clippy::cargo | lints for the cargo manifest | allow |
More to come, please file an issue if you have ideas!
The restriction
category should, emphatically, not be enabled as a whole. The contained
lints may lint against perfectly reasonable code, may not have an alternative suggestion,
and may contradict any other lints (including other categories). Lints should be considered
on a case-by-case basis before enabling.
Table of contents:
Usage
Below are instructions on how to use Clippy as a cargo subcommand, in projects that do not use cargo, or in Travis CI.
As a cargo subcommand (cargo clippy
)
One way to use Clippy is by installing Clippy through rustup as a cargo subcommand.
Step 1: Install Rustup
You can install Rustup on supported platforms. This will help us install Clippy and its dependencies.
If you already have Rustup installed, update to ensure you have the latest Rustup and compiler:
rustup update
Step 2: Install Clippy
Once you have rustup and the latest stable release (at least Rust 1.29) installed, run the following command:
rustup component add clippy
If it says that it can't find the clippy
component, please run rustup self update
.
Step 3: Run Clippy
Now you can run Clippy by invoking the following command:
cargo clippy
Automatically applying Clippy suggestions
Clippy can automatically apply some lint suggestions, just like the compiler. Note that --fix
implies
--all-targets
, so it can fix as much code as it can.
cargo clippy --fix
Workspaces
All the usual workspace options should work with Clippy. For example the following command
will run Clippy on the example
crate:
cargo clippy -p example
As with cargo check
, this includes dependencies that are members of the workspace, like path dependencies.
If you want to run Clippy only on the given crate, use the --no-deps
option like this:
cargo clippy -p example -- --no-deps
Using clippy-driver
Clippy can also be used in projects that do not use cargo. To do so, run clippy-driver
with the same arguments you use for rustc
. For example:
clippy-driver --edition 2018 -Cpanic=abort foo.rs
Note that clippy-driver
is designed for running Clippy only and should not be used as a general
replacement for rustc
. clippy-driver
may produce artifacts that are not optimized as expected,
for example.
Travis CI
You can add Clippy to Travis CI in the same way you use it locally:
language: rust
rust:
- stable
- beta
before_script:
- rustup component add clippy
script:
- cargo clippy
# if you want the build job to fail when encountering warnings, use
- cargo clippy -- -D warnings
# in order to also check tests and non-default crate features, use
- cargo clippy --all-targets --all-features -- -D warnings
- cargo test
# etc.
Note that adding -D warnings
will cause your build to fail if any warnings are found in your code.
That includes warnings found by rustc (e.g. dead_code
, etc.). If you want to avoid this and only cause
an error for Clippy warnings, use #![deny(clippy::all)]
in your code or -D clippy::all
on the command
line. (You can swap clippy::all
with the specific lint category you are targeting.)
Configuration
Allowing/denying lints
You can add options to your code to allow
/warn
/deny
Clippy lints:
-
the whole set of
Warn
lints using theclippy
lint group (#![deny(clippy::all)]
). Note thatrustc
has additional lint groups. -
all lints using both the
clippy
andclippy::pedantic
lint groups (#![deny(clippy::all)]
,#![deny(clippy::pedantic)]
). Note thatclippy::pedantic
contains some very aggressive lints prone to false positives. -
only some lints (
#![deny(clippy::single_match, clippy::box_vec)]
, etc.) -
allow
/warn
/deny
can be limited to a single function or module using#[allow(...)]
, etc.
Note: allow
means to suppress the lint for your code. With warn
the lint
will only emit a warning, while with deny
the lint will emit an error, when
triggering for your code. An error causes Clippy to exit with an error code, so
is useful in scripts like CI/CD.
If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to Clippy during the run:
To allow lint_name
, run
cargo clippy -- -A clippy::lint_name
And to warn on lint_name
, run
cargo clippy -- -W clippy::lint_name
This also works with lint groups. For example, you can run Clippy with warnings for all lints enabled:
cargo clippy -- -W clippy::pedantic
If you care only about a single lint, you can allow all others and then explicitly warn on the lint(s) you are interested in:
cargo clippy -- -A clippy::all -W clippy::useless_format -W clippy::...
Configure the behavior of some lints
Some lints can be configured in a TOML file named clippy.toml
or .clippy.toml
. It contains a basic variable = value
mapping e.g.
avoid-breaking-exported-api = false
disallowed-names = ["toto", "tata", "titi"]
The table of configurations contains all config values, their default, and a list of lints they affect. Each configurable lint , also contains information about these values.
For configurations that are a list type with default values such as
disallowed-names,
you can use the unique value ".."
to extend the default values instead of replacing them.
# default of disallowed-names is ["foo", "baz", "quux"]
disallowed-names = ["bar", ".."] # -> ["bar", "foo", "baz", "quux"]
Note
clippy.toml
or.clippy.toml
cannot be used to allow/deny lints.
To deactivate the âfor further information visit lint-linkâ message you can
define the CLIPPY_DISABLE_DOCS_LINKS
environment variable.
Specifying the minimum supported Rust version
Projects that intend to support old versions of Rust can disable lints pertaining to newer features by specifying the minimum supported Rust version (MSRV) in the Clippy configuration file.
msrv = "1.30.0"
Alternatively, the rust-version
field
in the Cargo.toml
can be used.
# Cargo.toml
rust-version = "1.30"
The MSRV can also be specified as an attribute, like below.
#![feature(custom_inner_attributes)]
#![clippy::msrv = "1.30.0"]
fn main() {
...
}
You can also omit the patch version when specifying the MSRV, so msrv = 1.30
is equivalent to msrv = 1.30.0
.
Note: custom_inner_attributes
is an unstable feature, so it has to be enabled explicitly.
Lints that recognize this configuration option can be found here
Contributing
If you want to contribute to Clippy, you can find more information in CONTRIBUTING.md.
License
Copyright 2014-2024 The Rust Project Developers
Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or https://www.apache.org/licenses/LICENSE-2.0> or the MIT license <LICENSE-MIT or https://opensource.org/licenses/MIT>, at your option. Files in the project may not be copied, modified, or distributed except according to those terms.
Footnotes
-
Some use cases for
restriction
lints include:- Strict coding styles (e.g.
clippy::else_if_without_else
). - Additional restrictions on CI (e.g.
clippy::todo
). - Preventing panicking in certain functions (e.g.
clippy::unwrap_used
). - Running a lint only on a subset of code (e.g.
#[forbid(clippy::float_arithmetic)]
on a module).
- Strict coding styles (e.g.
Top Related Projects
Format Rust code
A Rust compiler front-end for IDEs
Automatically generates Rust FFI bindings to C (and some C++) libraries.
Repository for the Rust Language Server (aka RLS)
A guide to how rustc works and how to contribute to it.
Convert designs to code with AI
Introducing Visual Copilot: A new AI model to turn Figma designs to high quality code using your components.
Try Visual Copilot